Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md to represent the recent build dependencies #408

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

taurus-forever
Copy link
Contributor

Issue:
The previous CONTRIBUTION guild didn't represent the latest code state and had missing mandatory dependencies installation.

Solution:
Update the guild providing the copy&paste manuals to:

  • install all the necessary build dependencies
  • document and avoid the possible pitfalls

…endencies

* install all the necessary build dependencies
* document and avoid the possible pitfails
@taurus-forever taurus-forever changed the title Update CONTRIBUTING.md to represent the recent build improvements/dep… Update CONTRIBUTING.md to represent the recent build dependencies Mar 20, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dragomirp dragomirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding @a-velasco to the review.

Copy link
Contributor

@a-velasco a-velasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contact link (L11) should probably be updated to our Matrix channel at https://matrix.to/#/#charmhub-data-platform:ubuntu.com

Otherwise, LGTM

Copy link
Member

@lucasgameiroborges lucasgameiroborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@taurus-forever taurus-forever merged commit 4d3b6cc into main Apr 18, 2024
3 checks passed
@taurus-forever taurus-forever deleted the alutay/contribute_guide branch April 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants